[PATCH:xdm 5/5] Simplify FailedLogin code

[Alan Coopersmith]

On 06/ 3/11 03:37 AM, walter harms wrote:
> mmmh, you are changing
> FailedLogin (d, struct greet_info) into FailedLogin (d, char *)
> 
> maybe it is better to keep greet_info as future version
> may need additional info. I would stick with struct greet_info
> and use greet->name instead username.
> 
> It is not a real problem just my experience.

This isn't a widely called API, just a local helper function called
exactly twice - as the patch shows it's trivial to update all the callers
if and when we find a need for some other arguments.

Until then, this gets rid of the need to shove username into greet->name
temporarily and then rip it back out just to satisfy the previous design.

I'll take better and more maintainable code now against a small chance of
having to do 2 minutes more work at some future point if we find a need
for some other bit of the greet struct.

-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System