[PATCH] xf86AutoConfig: Try newport on mips.

Mark Kettenis mark.kettenis at xs4all.nl
Fri Jun 3 09:04:03 PDT 2011


> Date: Fri, 3 Jun 2011 17:42:45 +0200
> From: Cyril Brulebois <kibi at debian.org>
> 
> Hi Mark.
> 
> Cyril Brulebois <kibi at debian.org> (27/02/2011):
> > Mark Kettenis <mark.kettenis at xs4all.nl> (27/02/2011):
> > > Not necessary a good idea.  The autoconfig code was broken some time
> > > ago by a "all-the-world-is-PCI" believer some time ago.  The
> > > breakage is that if you list more than a single "possible" video
> > > driver, things break.  That's why we actually have a diff in the
> > > OpenBSD tree now that changes the
> > >=20
> > >   #elif defined(__sparc__) && !defined(sun)
> > > [=E2=80=A6]
> >=20
> > that probably should land upstream?
> 
> That still stands.

Perhaps.

> > > If the Linux community thinks this is still a good idea, you could
> > > do something similar and use:
> > >=20
> > >   #elif define(__mips__) && defined(__linux__)
> >=20
> > FWIW, I'm mostly proxying Bernhard's patch, I can't unfortunately
> > perform tests on those systems, being under Linux or other systems.
> 
> Since it just works for Bernhard, since you already have
> platform-specific tricks, and since Matt has r-b'd this patch, I think
> I'll just go ahead and include it in my pull request, and leave it up
> to you folks to push your changes. Unless you have a last-minute
> objection?

Sorry, but my objection still stands.  Please restrict that change to
only affect Linux as I suggested, or drop it altogether.


More information about the xorg-devel mailing list