[PATCH libXi] Set the raw event's sourceid in XI 2.1 (#34240)

Daniel Stone daniel at fooishbar.org
Fri Jul 29 03:10:59 PDT 2011


Hi,

On Fri, Jul 29, 2011 at 10:54:34AM +0100, Daniel Stone wrote:
> On Fri, Jul 29, 2011 at 11:05:29AM +1000, Peter Hutterer wrote:
> > +#if (defined XI_2_Major) && (defined XI_2_1_Minor)
> > +    out->sourceid       = in->sourceid;
> > +#else
> > +    out->sourceid       = 0;
> > +#endif
> >      out->flags          = in->flags;
> >  
> >      out->valuators.mask_len = in->valuators_len * 4;
> 
> This would probably be better as:
>     XExtDisplayInfo *info = XInput_find_display(cookie->display);
>     [...]
> #if defined(XI_2_Major) && defined(XI_2_1_Minor)
>     if (_XiCheckExtInit(dpy, XInput_2_1, info)
                                               ^ != -1

Clearly I should've actually drunk my coffee this morning rather than
spilling it all over my shirt.

Cheers,
Daniel


More information about the xorg-devel mailing list