[PATCH RFC] Terminate the log with one last message.

Jeremy Huddleston jeremyhu at apple.com
Mon Jul 25 17:03:54 PDT 2011


Also, would you mind squashing this into your commit as well?  After that and cleaning up the ones in xwin (previous email),

Tested-by: Jeremy Huddleston <jeremyhu at apple.com>
Reviewed-by: Jeremy Huddleston <jeremyhu at apple.com>

diff --git a/hw/xquartz/darwin.c b/hw/xquartz/darwin.c
index a946448..f19d7bf 100644
--- a/hw/xquartz/darwin.c
+++ b/hw/xquartz/darwin.c
@@ -768,7 +768,7 @@ void ddxUseMsg( void )
  */
 void ddxGiveUp( enum ExitCode error )
 {
-    ErrorF( "Quitting Xquartz\n" );
+    LogClose(error);
 }


On Jul 25, 2011, at 15:06, Peter Hutterer wrote:

> On Mon, Jul 25, 2011 at 09:28:53AM +0100, Daniel Stone wrote:
>> On Wed, Jul 20, 2011 at 01:17:43PM +1000, Peter Hutterer wrote:
>>> Instead of just closing the log when everything is done, put one more
>>> message in stating that we're actually terminating. Users or scripts that
>>> look at the Xorg.log will then know that a) the server has terminated
>>> properly and b) why the server terminated (to some degree, given that most
>>> real-world errors will be caused by AbortServer()).
>>> 
>>> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
>> 
>> Reviewed-by: Daniel Stone <daniel at fooishbar.org>
> 
> Thanks. Jeremy, can you let this patch go through your tree, just so we're
> sure it didn't break XQuartz.
> Jon, if you could test this for XWin too that'd be much appreciated.
> 
> Cheers,
>  Peter
> 



More information about the xorg-devel mailing list