[PATCH evtest 2/2] Add one-shot query functionality

[Daniel Drake]

On 17 July 2011 13:59, walter harms <wharms at bfs.de> wrote:
> did you consider NULL as terminater for the query_modes array ?

Apples vs oranges, in my opinion. I prefer the approach taken in the
patch. Is there a clear argument to go with the NULL terminator?

> When you want to print an error you would be more verbose like
> fprintf(stderr,"%s:failed to get state from ioctl for device %s\n",__func__,device);
>
> same with open above
> fprintf(stderr,"%s:Can not open() %s\n",__func__,device);

perror() makes the error message more informative than it looks. I
don't see the value of printing the function name, this would imply
that you're going to look in the source code, in which case it is
obvious where the message came from.

I've made changes based on the other comments.

Thanks,
Daniel