[PATCH] xf86-input-palmax: Return proper default for unknown values in pInfo->device_control.

Peter Hutterer peter.hutterer at who-t.net
Sun Jul 17 18:41:23 PDT 2011


On Fri, Jul 15, 2011 at 05:23:23PM -0700, Terry Lambert wrote:
> Signed-off-by: Terry Lambert <tlambert at chromium.org>
> Reviewed-by: Stephane Marchesin <marcheu at chromium.org>
> ---
>  src/xf86Palmax.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/xf86Palmax.c b/src/xf86Palmax.c
> index bb77f07..f77888a 100644
> --- a/src/xf86Palmax.c
> +++ b/src/xf86Palmax.c
> @@ -543,7 +543,7 @@ xf86PmxControl(DeviceIntPtr	dev,
>  		return Success;
>  	default:
>  		ErrorF("unsupported mode=%d\n", mode);
> -		return !Success;
> +		return BadValue;
>  	}
>  }
>  
> -- 
> 1.7.3.1

did you test this patch? You should have seen a nice configure error
message:

**************************************************************
This driver is unmaintained and will not receive further
patches. If you have a need for this driver, please file a bug
on http://bugs.freedesktop.org.

**************************************************************

The same error should be displayed for summa, digitaledge, ur98, jamstudio,
tek4957 and magictouch.
Unless you're planning on becoming the maintainer for these drivers (there
are more exciting career plans), I'll just skip the patches for those.

Cheers,
  Peter


More information about the xorg-devel mailing list