[PATCH] xserver: Fix double free's in config file parser

Keith Packard keithp at keithp.com
Thu Jul 14 09:26:25 PDT 2011


On Fri, 15 Jul 2011 01:36:05 +1000, Benjamin Herrenschmidt <benh at kernel.crashing.org> wrote:
> On Thu, 2011-07-14 at 07:57 -0700, Dan Nicholson wrote:
> > I also see a couple instances of "free (val.str)" in parser/Files.c
> > that don't set it to NULL afterward. Yay for custom parsers! With
> > those two instances fixed:
> 
> Hrm, did I have a grep failure ? Oh... I see, I didn't catch the space
> between free and (val.str). I can send a newer patch tomorrow, or an
> addon, let me know, I'm off to bed now.

Might as well send a single patch which fixes all of them in one go.

I also wouldn't mind seeing a patch to replace 'val' with a slightly
more appropriate name :-)

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110714/0042380c/attachment.pgp>


More information about the xorg-devel mailing list