[PATCH v2 00/25] Various fixes based on static analysis - remaining patches

[Erkki Seppälä]

Here are the remaining patches of the libx11 static analysis batch
that have not yet received feedback from the list. This batch has the
comments fixed so that the actual change is first, while the diagnosis
from the tool follows, thus making git shortlog more useful.

Next up, pull-request :).

Ander Conselvan de Oliveira (6):          
      property_return was free'd before and in the case the conditional is     true, the call to XcmsGetProperty faile
      property_return was not free'd if the allocation of pRedTbl failed.
      The rest of the code uses goto's to free memory allocated later     and prevent memory leaks, but there were sev
      Properly handle the return value of XGetWindowProperty by considering if after the loop as well.
      info_list->watch_data was being reallocated, but the return value of the reallocation was stored only into a loc
      Fixed by zero'ing conv on allocation. Then close_converter works properly.

Erkki Seppälä (19):
      Fixed a missing call to XFreeFont
      Removed unused assignment
      Removed unused assignment
      Zero-initialized new
      Fixed by using strncpy and explicitly terminating the buffer
      Fixed memory leak by adding Xfree
      Fixed memory leak by adding Xfree and initializing missing_list with NULL
      Fixed memory leak by adding Xfree
      Fixed memory leak by adding Xfree
      Fixed memory leak by adding Xfree
      Fixed memory leak by adding Xfree
      Instead of copying the value returned by get_prop_name and then releasing it, directly use the return value of g
      The NEWTABLE macro missed freeing its allocated memory on subsequent memory allocation errors. Added call to Xfr
      Fixed the handling of the extremely unlikely situation of fstat failing
      Initialize local variable
      Checked return value of XGetWindowProperty and return false if it fails.
      Fixed by negative value to memcpy by checking for the negative return value of _Xlcwctomb and returning 0/XLooku
      Removed superfluous check for NULL target_dir; it is already handled     before this code.
      Removed superfluous check for NULL target_dir; it is already handled     before this code.

 modules/im/ximcp/imLcLkup.c |    4 ++++
 modules/im/ximcp/imRm.c     |    4 ++++
 modules/im/ximcp/imRmAttr.c |    7 +++++--
 modules/im/ximcp/imTrX.c    |   33 +++++++++++++++++++++------------
 modules/lc/def/lcDefConv.c  |    2 +-
 modules/lc/gen/lcGenConv.c  |    2 +-
 src/GetProp.c               |    2 +-
 src/ImUtil.c                |    1 +
 src/XlibInt.c               |    8 +++++---
 src/Xrm.c                   |   10 +++++++++-
 src/xcms/LRGB.c             |   25 ++++++++++---------------
 src/xcms/cmsColNm.c         |    4 ++--
 src/xcms/cmsProp.c          |   11 ++++++-----
 src/xlibi18n/XDefaultOMIF.c |    9 +++++----
 src/xlibi18n/lcFile.c       |    6 ++----
 src/xlibi18n/lcGeneric.c    |    2 +-
 16 files changed, 78 insertions(+), 52 deletions(-)