[PATCH] libtXt: add simple example for XtAppNextEvent() man page

Alan Coopersmith alan.coopersmith at oracle.com
Sun Jan 23 09:29:13 PST 2011


Thanks for putting these together - I don't know enough about libXt to comment
on the code examples, but hopefully they'll help others.

Some notes for all these patches:

  - please don't restore the old/obsolete CVS id tags that we have
    previously removed, like this:

> +.\" $Xorg: XtAppNEv.man,v 1.3 2000/08/17 19:41:58 cpqbld Exp $

  - The preferred subject line format would be:
	[PATCH libXt] add simple example for XtAppNextEvent() man page

    The bits in [] are to provide information to the e-mail readers, letting
    us know which module it's for, but are removed by git when applying the
    patch, leaving the rest of the subject line as the single line summary of
    the commit that appears in the changelog and release announcement, and
    you don't need to preface all of those with libXt: when you are reading
    the libXt announcements or changelogs.

    Also, you shouldn't duplicate the subject line in the body of the commit
    message - once is enough.

  - In the examples:

> +#include <Xaw/Label.h>
> +/* gcc -I /usr/include/X11/ sample.c -o sample -lX11 -lXaw */

That should be #include <X11/Xaw/Label.h>, and then the "-I /usr/include/X11/"
is not needed.  We never write code such that "-I /usr/include/X11/" is needed,
and shouldn't show examples that do either.

-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System



More information about the xorg-devel mailing list