[PATCH 2/2] libXft: remove AC_PROG_CC as it overrides AC_PROG_C_C99

[Dan Nicholson]

On Wed, Jan 19, 2011 at 11:53 AM, Roberto Branciforti <rbbrnc at gmail.com> wrote:
> XORG_STRICT_OPTION from XORG_DEFAULT_OPTIONS calls AC_PROG_C_C99. This
> sets gcc with -std=gnu99. If AC_PROG_CC macro is called afterwards, it
> resets CC to gcc.
>
> Signed-off-by: Roberto Branciforti <rbbrnc at gmail.com>
> ---
>  configure.ac |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index f35eb91..6ef023a 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -43,7 +43,7 @@ XORG_DEFAULT_OPTIONS
>  AM_CONFIG_HEADER(config.h)
>
>  # checks for progs
> -AC_PROG_CC
> +#AC_PROG_CC
>  AC_PROG_LIBTOOL
>  AC_PROG_SED

This seems like more of a problem with the macros. I don't know why
XORG_STRICT_OPTION doesn't just AC_REQUIRE AC_PROG_CC so that we don't
get these kinds of issues. However, for this particular case I think
it would be better if we just moved the XORG_DEFAULT_OPTIONS call
below AC_PROG_CC. If we comment or remove AC_PROG_CC, then it becomes
really unclear that we're getting it implicitly through
XORG_DEFAULT_OPTIONS.

--
Dan