[PATCH] Xi: reset remainders when warping the device.

Simon Thum simon.thum at gmx.de
Tue Jan 11 14:57:52 PST 2011


On 01/07/2011 12:53 AM, Peter Hutterer wrote:
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> ---
>  Xi/xiwarppointer.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/Xi/xiwarppointer.c b/Xi/xiwarppointer.c
> index 7276e6f..c01b115 100644
> --- a/Xi/xiwarppointer.c
> +++ b/Xi/xiwarppointer.c
> @@ -192,6 +192,8 @@ ProcXIWarpPointer(ClientPtr client)
>      /* if we don't update the device, we get a jump next time it moves */
>      pDev->last.valuators[0] = x;
>      pDev->last.valuators[1] = y;
> +    pDev->last.remainder[0] = 0;
> +    pDev->last.remainder[1] = 0;
It's not that heaven will fall down on us, but this should not be done
if the motion is relative to the current pointer postion (dest_w is
none) and was not constrained. The code will add noise in that case.

But since that is an unlikely issue, assume my r-b.

Cheers,

Simon

>      miPointerUpdateSprite(pDev);
>  
>      /* FIXME: XWarpPointer is supposed to generate an event. It doesn't do it



More information about the xorg-devel mailing list