[PATCH] resource: Remove a useless iteration

Adam Jackson ajax at redhat.com
Mon Jan 10 14:15:58 PST 2011


On Mon, 2011-01-10 at 17:49 +0000, Daniel Stone wrote:
> On Mon, Jan 10, 2011 at 12:44:23PM -0500, Adam Jackson wrote:
> > v2: More aggressive loop rewrite pointed out by Daniel.
> 
> Sorry, I should've mentioned this the first time -- only realised after
> I sent the mail -- but:
> 
> > +    for (i = 0; i < clientTable[client].buckets; i++) {
> > +	res = clientTable[client].resources[i];
> 
> I think you need a:
>     if (!res)
>         break;
> here?

Enh.  Not really, but v2 is broken for different reasons.

However the whole thing is broken for even more different reasons, so
I'm just going to drop this patch from the next pull request.

- ajax



More information about the xorg-devel mailing list