[PATCH] libXi: Fix passive grabs
Peter Hutterer
peter.hutterer at who-t.net
Sun Jan 9 16:14:31 PST 2011
On Sat, Jan 08, 2011 at 11:54:14AM +0100, Philipp Reh wrote:
> _XIPassiveGrabDevice, which is called by alle the passive grab functions,
> wrongly returns an error when it shouldn't.
> The attached patch adds the missing "not" to properly test the error
> condition of _XReply.
oops.
ACK, please resend the patch as signed-off git-formatted patch and I'll push
it
http://wiki.x.org/wiki/Development/Documentation/SubmittingPatches
thanks,
Peter
> --- src/XIPassiveGrab.c 2011-01-07 19:43:44.000000000 +0100
> +++ src/XIPassiveGrab.c 2011-01-07 19:43:51.000000000 +0100
> @@ -73,7 +73,7 @@ _XIPassiveGrabDevice(Display* dpy, int d
>
> free(buff);
>
> - if (_XReply(dpy, (xReply *)&reply, 0, xTrue))
> + if (!_XReply(dpy, (xReply *)&reply, 0, xTrue))
> {
> UnlockDisplay(dpy);
> SyncHandle();
>
More information about the xorg-devel
mailing list