[PATCH] xfree86: Use last Screen section found to prefer xorg.conf (#32430)

[Dan Nicholson]

On Fri, Jan 7, 2011 at 8:15 AM, Julien Cristau <jcristau at debian.org> wrote:
> On Fri, Jan  7, 2011 at 07:06:20 -0800, Dan Nicholson wrote:
>
>> Allowing multiple .conf files with xorg.conf.d works well for
>> InputClass where any section in xorg.conf would override settings from
>> previous .conf files typically installed by the distro. This does not
>> work well with Screen sections where the first section found has been
>> used when there is no Layout or the Layout doesn't specify a Screen.
>> Instead, use the last Screen section found to give preference to
>> xorg.conf and match the InputScreen semantics.
>>
>> X.Org Bug 32430 <https://bugs.freedesktop.org/show_bug.cgi?id=32430>
>>
>> Signed-off-by: Dan Nicholson <dbn.lists at gmail.com>
>> ---
>>  Looking through this code, the same situation occurs with layouts and
>>  devices. Not sure if those should get fixed in the same way.
>>
> I don't think we should change semantics like that.  The manpage says:
>
>       A Screen section is considered “active” if it is referenced
>       by an active ServerLayout  section  or  by  the  -screen  command  line
>       option.  If neither of those is present, the first Screen section found
>       in the config file is considered the active one.
>
> Same goes for ServerLayout.

Right. The issue is that now that all the xorg.conf.d files are
scanned prior to xorg.conf, it's entirely possible that the first
Screen section in xorg.conf won't be used. That's the issue that Felix
is having because his distro has cleverly stuck a default Screen
section in xorg.conf.d for him.

--
Dan