[PATCH 1/3] os: Add -displayfd option.
Alan Coopersmith
alan.coopersmith at oracle.com
Thu Jan 6 14:55:29 PST 2011
On 01/ 6/11 02:28 PM, Adam Jackson wrote:
> This option specifies a file descriptor in the launching process. X
> will scan for an available display number and write that number back to
> the launching process, at the same time as SIGUSR1 generation. This
> means display managers don't need to guess at available display numbers.
> As a consequence, if X fails to start when using -displayfd, it's not
> because the display was in use, so there's no point in retrying the X
> launch on a higher display number.
Seems like a good idea. In a similar vein, so does this if anyone wants
to code it up:
https://bugs.freedesktop.org/show_bug.cgi?id=32479 Please add a -minvt option
> @@ -356,11 +357,25 @@ NotifyParentProcess(void)
> kill (ParentProcess, SIGUSR1);
> }
> }
> + if (dynamic_display[0])
> + write(displayfd, dynamic_display, strlen(dynamic_display));
Should the fd be closed after the write()? Seems like it's left open, unused
for the life of the process, including being passed to forked children (xkbcomp).
--
-Alan Coopersmith- alan.coopersmith at oracle.com
Oracle Solaris Platform Engineering: X Window System
More information about the xorg-devel
mailing list