[PATCH xserver 16/17] Input: Add initial multitouch support from Xi 2.1

Peter Hutterer peter.hutterer at who-t.net
Thu Jan 6 14:49:08 PST 2011


On Thu, Jan 06, 2011 at 02:32:30PM -0500, Chase Douglas wrote:
> On 01/06/2011 12:57 PM, Daniel Stone wrote:
> > On Thu, Jan 06, 2011 at 10:18:00AM +1000, Peter Hutterer wrote:
> >> On Tue, Dec 28, 2010 at 05:58:07PM +0000, Daniel Stone wrote:
> >>> +typedef struct _TouchClassRec {
> >>> +    TouchAxisInfoPtr      axes;
> >>> +    unsigned short        num_axes;
> >>> +    TouchPointInfoPtr     touches;
> >>> +    unsigned short        num_touches;
> >>> +    CARD8                 mode;         /* ::XIDirectTouch, XIDependentTouch */
> >>> +    unsigned int          last_touchid;
> >>> +    int                   x_axis;       /* axis number */
> >>> +    int                   y_axis;       /* axis number */
> >>
> >> axis number?? is this to hold the axis index for the x/y axis?
> > 
> > Yeah, it is.
> > 
> >> why not force the implementation to have x/y on 0/1, that's what we do for
> >> pointer events too.
> > 
> > *shrug*, it was from Chase's original patch, but to be honest I don't
> > really see the harm in being slightly more flexible.
> 
> Uhhh... I had it as 0/1 originally, and it was due to one of Peter's
> comments that I changed it. Maybe I misunderstood? (Please don't make me
> go find the email :)

sorry, rings a bell now. nevermind my most recent comment, leave the code
as-is.

Cheers,
  Peter


More information about the xorg-devel mailing list