[PATCH modular 4/4] build.sh: relocate the test for the AMD Geode 32 bit CPU
Dan Nicholson
dbn.lists at gmail.com
Mon Jan 3 06:46:03 PST 2011
On Sun, Jan 2, 2011 at 5:58 AM, Gaetan Nadon <memsize at videotron.ca> wrote:
> Taking advantage of an exiting test for Linux.
> The driver does not compile on 64 bit CPU as it contains
> assembler code with 32 bit assumptions.
>
> Signed-off-by: Gaetan Nadon <memsize at videotron.ca>
> ---
> build.sh | 17 ++++++++---------
> 1 files changed, 8 insertions(+), 9 deletions(-)
>
> diff --git a/build.sh b/build.sh
> index cfbddba..4061384 100755
> --- a/build.sh
> +++ b/build.sh
> @@ -822,6 +822,14 @@ build_driver_video() {
> build driver xf86-video-sunffb
> build driver xf86-video-v4l
> build driver xf86-video-xgixp
> + case $HOST_CPU in
> + i*86)
> + # AMD Geode CPU. Driver contains 32 bit assembler code
> + build driver xf86-video-geode
> + ;;
> + *)
> + ;;
> + esac
FYI, it's superfluous to have the wildcard fallback case here. It's
not like C case statements where you need to match any possible match.
Looks good otherwise.
Reviewed-by: Dan Nicholson <dbn.lists at gmail.com>
More information about the xorg-devel
mailing list