[PULL] Server build fixes

Dan Nicholson dbn.lists at gmail.com
Sun Feb 27 14:29:30 PST 2011


On Sun, Feb 27, 2011 at 03:26:32AM +0100, Cyril Brulebois wrote:
> Hi,
> 
> Keith Packard <keithp at keithp.com> (26/02/2011):
> > I read through the automake docs and they suggest placing a
> > dependency on the generated configuration header file. We've got
> > several, but there's the auto-generated do-not-use-config.h which
> > holds all of the cpp defines which sdksyms.c may use.
> > 
> > I think this is what we want: […]
> 
> at least, this fixes the issue I was having. Steps to reproduce:
>   git checkout master
>   git clean -xdf
>   autoreconf -vfi
>   ./configure
>   make dist
>   # elsewhere
>   tar xf $tarball
>   cd $directory
>   ./configure --disable-xv
> 
> With master → fails, master + your patch → works. Accordingly:
> 
> Tested-by: Cyril Brulebois <kibi at debian.org>
> 
> Also, the generated sdksyms.c lands in the build directory, meaning
> one can happily do stuff like:
>   mkdir build1 build2
>   (cd build1 && ../configure --disable-stuff)
>   (cd build2 && ../configure --enable-stuff)
>   make -C build1
>   make -C build2
> 
> And even “make” build1 and build2 in parallel.
> 
> (FYI, that's what we do in Debian: we build two flavours; one regular,
> one for the debian-installer; with a configuration phase, then a build
> phase; hence my issues with --disable-xv and the like. ;))

I rolled Keith's diff in with my own and added the fix of actually
making sdksyms.dep be a prerequisite for sdksyms.c. I think that should
fix all the cases.

--
Dan


More information about the xorg-devel mailing list