[PULL] Server build fixes

Cyril Brulebois kibi at debian.org
Sat Feb 26 06:33:20 PST 2011


Hi,

Keith Packard <keithp at keithp.com> (25/02/2011):
> On Fri, 25 Feb 2011 06:43:58 -0800, Dan Nicholson <dbn.lists at gmail.com> wrote:
> 
> > Dan Nicholson (2):
> >       xfree86: Allow sdksyms.dep to be included portably
> >       dmx: Construct paths in doxygen.conf to fix VPATH builds
> 
> Merged.
>    780a77a..6b951de  master -> master

I fear that the sdksyms part is broken. If one builds with some
options different than the ones used to generate the tarball, the file
isn't generated again, leading to such issues.

Example:
|   CC     sdksyms.lo
| ../../../../hw/xfree86/loader/sdksyms.c:416: error: 'AugmentSelf' undeclared here (not in a function)
| ../../../../hw/xfree86/loader/sdksyms.c:417: error: 'RegisterAuthorizations' undeclared here (not in a function)

if xdcmp is disabled, since in include/os.h we have:
| #if XDMCP
| extern _X_EXPORT void AugmentSelf(pointer /*from*/, int /*len*/);
| extern _X_EXPORT void RegisterAuthorizations(void);
| #endif

A wild guess would be the “touch” added to configure leading to an
up-to-date target. Also, I'm not sure it's a good idea to ship
sdksyms.c in the tarball? (It was shipped already in rc3 and before,
but that didn't lead to any issues.)

KiBi.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110226/09e22c43/attachment.pgp>


More information about the xorg-devel mailing list