[PATCH] randr: Add 'set' fields to SetCrtcConfigs request

[Keith Packard]

On Wed, 23 Feb 2011 10:16:46 -0800, Aaron Plattner <aplattner at nvidia.com> wrote:

> randrproto.txt says nothing about SetCrtcMode.
...
> randrproto.txt says nothing about SetCrtcOutputs.  The interplay encoded
> here probably ought to be described in the protocol doc.

Yeah, randrproto.txt is missing some text there...

> > -    screen_config.screen_pixmap_width = stuff->screenPixmapWidth;
> > -    screen_config.screen_pixmap_height = stuff->screenPixmapHeight;
> > -    screen_config.screen_width = stuff->screenWidth;
> > -    screen_config.screen_height = stuff->screenHeight;
> > -    screen_config.mm_width = stuff->widthInMillimeters;
> > -    screen_config.mm_height = stuff->heightInMillimeters;
> > +    if (num_configs > 0) {
> 
> Existing bug, but it's not clear from randrproto.txt that RRSetCrtcConfigs
> doesn't do anything if 'set' doesn't contain SetScreenCrtcs.  From the
> wording of the protocol doc, I would expect set = RR_SetScreenPixmapSize |
> RR_SetScreenSizeInMillimeters | RR_SetScreenSize to change those three
> things.

Agreed, this is a bug.

> Other than the protocol doc comments and the existing bug noted above,
> 
> Reviewed-by: Aaron Plattner <aplattner at nvidia.com>
> 
> However, I do need to object strongly to such a major protocol change being
> made after RC2 of a release cycle.  We're supposed to be making only
> critical bug fixes at this point!  Planning fail.

So, I think I can resolve these issues, and I thank you for your
review. I clearly need to be more careful about getting protocol changes
and client API reviews made before committing code into the X server.

As an alternative plan, I've got a server branch with all of RandR 1.4
removed so that we can properly review the protocol, client library
interfaces and driver interfaces.

git://people.freedesktop.org/~keithp/xserver.git backout-randr

I'd love to hear opinions on which option people would be happiest with.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110223/43683592/attachment.pgp>