[PATCH:xdm 3/5] Remove forced cursor move for no-echo entry when echoPasswd not set

[Mark Kettenis]

> From: Alan Coopersmith <alan.coopersmith at oracle.com>
> Date: Sat, 19 Feb 2011 22:36:39 -0800
> 
> If you want to have it, for feedback that's visible to the user but
> harder to shoulder-surf, enable echoPasswd and set the echoPasswdChar
> to empty/space.

But that would move the pixel more than one pixel per character isn't
it, making it easier to spot the password length.

> Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
> ---
>  greeter/Login.c |    6 ------
>  1 files changed, 0 insertions(+), 6 deletions(-)
> 
> diff --git a/greeter/Login.c b/greeter/Login.c
> index 18a3f86..5bc8c05 100644
> --- a/greeter/Login.c
> +++ b/greeter/Login.c
> @@ -495,12 +495,6 @@ realizeCursor (LoginWidget w, GC gc)
>  
>  	    x += len*TEXT_WIDTH(text, w->login.echo_passwd_char, 1);
>  	}
> -	else
> -	{
> -	    /* Move cursor one pixel per character to give some feedback
> -	       without giving away the password length */
> -	    x += PROMPT_CURSOR(w, w->login.activePrompt);
> -	}
>  	break;
>      }