[PATCH libFS] Silence gcc warning.

Julien Cristau jcristau at debian.org
Sat Feb 19 06:04:24 PST 2011


On Fri, Feb 18, 2011 at 21:17:12 +0100, Cyril Brulebois wrote:

> Fix the build with CFLAGS="-Wall -Werror":
> |   CC     FSGetErrorText.o
> | cc1: warnings being treated as errors
> | FSGetErrorText.c: In function ‘CheckErrorMessage’:
> | FSGetErrorText.c:43: error: format ‘%d’ expects type ‘int’, but argument 5 has type ‘long unsigned int’
> 
> An int is likely to be sufficient for this buffer's size…
> 
> Signed-off-by: Cyril Brulebois <kibi at debian.org>
> ---
>  test/FSGetErrorText.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/test/FSGetErrorText.c b/test/FSGetErrorText.c
> index 31523c6..f9a88d2 100644
> --- a/test/FSGetErrorText.c
> +++ b/test/FSGetErrorText.c
> @@ -40,7 +40,7 @@ CheckErrorMessage(FSServer *srv, int code, const char *codestr)
>  
>      if (!FSGetErrorText(srv, code, buf, sizeof(buf))) {
>  	fprintf(stderr, "FSGetErrorText(srv, %s (%d), buf, %d) failed",
> -		codestr, code, sizeof(buf));
> +		codestr, code, (int) sizeof(buf));
>  	return 0;
>      }
>  
Or you could use %zu in the format string and avoid the cast?

Cheers,
Julien


More information about the xorg-devel mailing list