[PATCH 2/8] int10: warning fix

[Adam Jackson]

On Feb 12, 2011, at 5:05 PM, Mark Kettenis wrote:

>> From: Adam Jackson <ajax at redhat.com>
>> Date: Sun, 23 Jan 2011 23:18:06 -0500
>> 
>> helper_exec.c: In function 'pciCfg1in':
>> helper_exec.c:507:4: warning: passing argument 2 of 'pci_device_cfg_read_u32' from incompatible pointer type
>> /usr/include/pciaccess.h:153:5: note: expected 'uint32_t *' but argument is of type 'CARD32 *'
> 
> That fix isn't so obvious to me.  Why is your compiler warning about
> this?  Is it just because you're on a 32-bit system, where CARD32 is
> typedefed as "unsigned long", but uint32_t is typedefed as "unsigned
> int"?

Yeah.  The other way to fix this is to fix CARD32 in Xmd.h, but I suspect that
introduces more warnings everywhere else in the world than it fixes here.

- ajax