[PATCH 3/8] fbdevhw: Remove the non-sysfs hack for mapping from PCI to fbdev

Mark Kettenis mark.kettenis at xs4all.nl
Mon Feb 14 05:16:47 PST 2011


> Date: Sun, 13 Feb 2011 08:48:16 -0800
> From: Alan Coopersmith <alan.coopersmith at oracle.com>
> 
> On 02/12/11 02:13 PM, Mark Kettenis wrote:
> >> From: Adam Jackson <ajax at redhat.com>
> >> Date: Sun, 23 Jan 2011 23:18:07 -0500
> >>
> >> It's broken for devices with BARs above 4G, and the sysfs method should
> >> work everywhere anyway.  As a pleasant side effect, this fixes some
> >> warnings:
> >>
> >> fbdevhw.c: In function 'fbdev_open_pci':
> >> fbdevhw.c:333:4: warning: cast from pointer to integer of different size
> >> fbdevhw.c:334:4: warning: cast from pointer to integer of different size
> >> fbdevhw.c:336:4: warning: cast from pointer to integer of different size
> >> fbdevhw.c:337:4: warning: cast from pointer to integer of different size
> >>
> >> Signed-off-by: Adam Jackson <ajax at redhat.com>
> > 
> > That code should really be #ifdef __linux__ to make it obvious that it
> > is OS-specific code.  Anyway, if the Linux community is happy with it,
> > I am as well ;).
> 
> The entire fbdevhw.c is Linux-specific.  fbdevhwstubs.c is for the
> rest of us.  The "if" is just in the configure.ac & Makefile.am, not
> the C code.

Ah yes, I had forgotten about that.  Thanks for pointing this out.


More information about the xorg-devel mailing list