[PATCH v2: setxkbmap 2/3] Bug 34151: Potential bug and buffer overflow due to misused rules filename

[Alan Coopersmith]

On 02/12/11 02:06 AM, Van de Bugger wrote:
> Alan,
> 
> Did you build it before sending the patch? ;-)

I built it & tested it before doing the git commit and then trying to be
clever with git rebase -i to stick it in the right place in the series.
That's where I screwed up. 8-/

> Ok, seriously: Is there any tests for setxkbmap someone can run before
> sending the patch?

Not that I know of - I just did manual testing, such as:

./setxkbmap -I
./setxkbmap -I `perl -e 'print "A"x4000'` -rules foo
./setxkbmap -I foo
./setxkbmap -I /usr/share

And I ran a bunch of those under truss (like strace for Linux users) to
see what files it was trying to open.

-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System