[PATCH v2 03/10] dri2: Change driver interface to support DRI2Drawable

Pauli Nieminen ext-pauli.nieminen at nokia.com
Thu Feb 10 08:22:24 PST 2011


On 10/02/11 17:40 +0200, Ville Syrjälä wrote:
> On Tue, Feb 08, 2011 at 11:42:49PM +0200, ext Pauli wrote:
> > From: Pauli Nieminen <ext-pauli.nieminen at nokia.com>
> > 
> >  void
> > -DRI2WaitMSCComplete(ClientPtr client, DrawablePtr pDraw, int frame,
> > -                   unsigned int tv_sec, unsigned int tv_usec)
> > +DRI2WaitMSCComplete2(DRI2DrawablePtr pPriv, int frame,
> > +                    unsigned int tv_sec, unsigned int tv_usec,
> > +                    void *data)
> >  {
> > -    DRI2DrawablePtr pPriv;
> > -
> > -    pPriv = DRI2GetDrawable(pDraw);
> > -    if (pPriv == NULL)
> > -       return;
> > +    ClientPtr client = data;
> 
> Why void* instead of ClientPtr?
> 

Because driver shouldn't care what is in the data pointer.

Because it will contain special structure to track if client has disconnected
later on. Only reason to pass ClienPtr there for now is to make this patch
work without client state tracking.

> -- 
> Ville Syrjälä


More information about the xorg-devel mailing list