[PATCH 1/2] xkb: split out keymap compilation.

Dan Nicholson dbn.lists at gmail.com
Thu Feb 10 06:21:00 PST 2011


On Wed, Feb 9, 2011 at 9:34 PM, Peter Hutterer <peter.hutterer at who-t.net> wrote:
> Refacturing for simpler double-use in the next patch. No functional changes.
>
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>

Nice work cleaning up hairy code. I was going to ask a couple
questions about why things were done, but then read the second patch.
Although, you may want to note in your commit message that you're
"refactoring" the code. I don't think the XKB code can get any more
fractured.

Reviewed-by: Dan Nicholson <dbn.lists at gmail.com>


More information about the xorg-devel mailing list