[PATCH xserver v2] xf86cmap: Use old palette system for pseudocolour.

Michel Dänzer michel at daenzer.net
Wed Feb 9 01:48:24 PST 2011


On Fre, 2011-01-21 at 10:15 +0100, Michel Dänzer wrote: 
> From: Michel Dänzer <daenzer at vmware.com>
> 
> RandR doesn't seem to deal with pseudocolour at all, so without this the
> pseudocolour palette never gets loaded to the hardware.
> 
> v2: Move logic into xf86_crtc_supports_gamma().

Anyone? Should the server abort in this case instead? It certainly can't
work properly as it is.


> Signed-off-by: Michel Dänzer <daenzer at vmware.com>
> ---
>  hw/xfree86/modes/xf86Crtc.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/hw/xfree86/modes/xf86Crtc.c b/hw/xfree86/modes/xf86Crtc.c
> index c4470c3..a3a123e 100644
> --- a/hw/xfree86/modes/xf86Crtc.c
> +++ b/hw/xfree86/modes/xf86Crtc.c
> @@ -3262,6 +3262,10 @@ xf86_crtc_notify(ScreenPtr screen)
>  Bool
>  xf86_crtc_supports_gamma(ScrnInfoPtr pScrn)
>  {
> +    /* RandR doesn't seem to deal with PseudoColor */
> +    if (pScrn->defaultVisual == PseudoColor)
> +	return FALSE;
> +
>      if (xf86CrtcConfigPrivateIndex != -1) {
>  	xf86CrtcConfigPtr xf86_config = XF86_CRTC_CONFIG_PTR(pScrn);
>  	xf86CrtcPtr crtc;
> -- 
> 1.7.2.3
> 
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel


-- 
Earthling Michel Dänzer           |                http://www.vmware.com
Libre software enthusiast         |          Debian, X and DRI developer


More information about the xorg-devel mailing list