[PATCH 2/2] [libX11] xcms/cmsProp: don't deal with uninitialized values, fail instead

Alan Coopersmith alan.coopersmith at sun.com
Tue Feb 8 21:45:52 PST 2011


On 02/ 4/11 01:43 AM, Erkki Seppälä wrote:
> Properly handle the return value of XGetWindowProperty by considering
> if after the loop as well.
> 
> Using freed pointer "prop_ret"
> 
> There were numerous things wrong in how this function interacted with
> XGetWindowProperty.
> 
> None of the local variables were initialized and remained that way if
> the call to XGetWindowProperty returned 1 (not Succeed). That doesn't

s/Succeed/Success/

Nice explanation, made it easier to understand the changes to the code.

Reviewed-by: Alan Coopersmith <alan.coopersmith at oracle.com>

-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System


More information about the xorg-devel mailing list