[PATCH:libXt 2/3] GetResources: protect against underflow when type conversion fails

Alan Coopersmith alan.coopersmith at oracle.com
Fri Feb 4 22:29:59 PST 2011


Fix originally created by Leo Binchy for Sun to fix Solaris bug 1211553:
 XtVaCreateManagedWidget with list of resources XtVaTypedArg cause core dump

Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
---
 src/Resources.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/Resources.c b/src/Resources.c
index 304d3d5..dc0f563 100644
--- a/src/Resources.c
+++ b/src/Resources.c
@@ -857,7 +857,7 @@ static XtCacheRef *GetResources(
 		    register XtTypedArg* arg = typed_args + typed[j] - 1;
 		    register int i;
 
-		    for (i = num_typed_args - typed[j]; i; i--, arg++) {
+		    for (i = num_typed_args - typed[j]; i > 0; i--, arg++) {
 			*arg = *(arg+1);
 		    }
 		    num_typed_args--;
-- 
1.7.3.2



More information about the xorg-devel mailing list