[PATCH 7/9] dri2: Send events only to known clients

[Michel Dänzer]

On Fre, 2011-02-04 at 16:38 +0200, Pauli Nieminen wrote: 
> On 04/02/11 10:44 +0100, ext Michel Dänzer wrote:
> > On Don, 2011-02-03 at 19:48 +0200, Pauli wrote: 
> > > From: Pauli Nieminen <ext-pauli.nieminen at nokia.com>
> > > 
> > > If client disconnects and new client gets same id DRI2 events may end to
> > > wrong client. DRI2 reference list can be checked to see if the client
> > > still owns the DRI2Drawable.
> > 
> > In the radeon driver, this was solved by invalidating pending events
> > from a ClientStateCallback. See commit
> > 81360adffb2a66b9a95a38671f9227a9718c9841 ('radeon: proper DRI2 pending
> > events handling when client gone. (v6)') and the followup fix
> > f815e9c3c61b1ed73e7dd9383587efcdd8dfc07f ('Don't try to delete DRI2
> > event list entries that were never added. (Bug #31086)').
> 
> It is nice to have drivers working correctly.
> 
> But would it be better to handle all the special cases in common code? That
> would simplify driver side.

Sure, I'm just pointing out a better solution for the problem this patch
tries to solve.


-- 
Earthling Michel Dänzer           |                http://www.vmware.com
Libre software enthusiast         |          Debian, X and DRI developer