Pull request for reviewed static analysis fixes, second batch

Erkki Seppala erkki.seppala at vincit.fi
Tue Feb 1 23:33:22 PST 2011


The following changes since commit e994ab227ed28655565c3193e63733630105e7f9:
   Erkki Seppälä (1):
         Comparing array against NULL is not useful "&xkb->server->vmods 
!= NULL"

are available in the git repository at:

   git at gitorious.org:erkkise/libx11-fixes.git fixes-reviewed-2011-02-01

Alan Coopersmith (1):
       XDefaultOMIF.c: Fix memory leaks in get_font_name

Ander Conselvan de Oliveira (4):
       xcms/LRGB: Fix potential resource leak.
       xcms/LRGB: Add a label for freeing property_return.
       XlibInt: info_list->watch_data was reallocated, but result was 
discarded
       lc/def/lcDefConv: Use Xcalloc to avoid use of uninitialized memory

Erkki Seppälä (13):
       xcmx/cmxColNm: Removed unused assignments to pBuf (in two functions)
       xlibi18n/lcGeneric: Initialize uninitialized local variable
       ximcp/imRmAttr: Handle leaking colormap_ret
       ximcp/imRmAttr: Handle leaking missing_list
       ximcp/imRm: Handle leaking colormap_ret
       ImUtil: Handle a memory leak in one early return branch
       Xrm: NEWTABLE had a memory leak after a memory allocation error
       Xrm: Handle the extremely unlikely situation of fstat failing
       GetProp: Zero-initialized error so its resourceID field is 
initialized
       ximcp/imTrX: Handle failing XGetWindowProperty
       ximcp/imLckup: Handle negative return value from _Xlcwctomb
       xlibi18n/lcFile: Removed superfluous check for NULL target_dir
       XlibInt: Use strncpy+zero termination instead of strcpy to 
enforce buffer size

  modules/im/ximcp/imLcLkup.c |    4 ++++
  modules/im/ximcp/imRm.c     |    4 ++++
  modules/im/ximcp/imRmAttr.c |    7 +++++--
  modules/im/ximcp/imTrX.c    |   33 +++++++++++++++++++++------------
  modules/lc/def/lcDefConv.c  |    2 +-
  modules/lc/gen/lcGenConv.c  |    2 +-
  src/GetProp.c               |    2 +-
  src/ImUtil.c                |    1 +
  src/XlibInt.c               |    8 +++++---
  src/Xrm.c                   |   10 +++++++++-
  src/xcms/LRGB.c             |   22 ++++++++++------------
  src/xcms/cmsColNm.c         |    4 ++--
  src/xlibi18n/XDefaultOMIF.c |   10 ++--------
  src/xlibi18n/lcFile.c       |    6 ++----
  src/xlibi18n/lcGeneric.c    |    2 +-
  15 files changed, 69 insertions(+), 48 deletions(-)


More information about the xorg-devel mailing list