Patches for xf86-video-{tdfx,trident,xgi}

Mark Kettenis mark.kettenis at xs4all.nl
Fri Dec 30 04:07:32 PST 2011


> From: Johannes Obermayr <johannesobermayr at gmx.de>
> Date: Fri, 30 Dec 2011 12:50:18 +0100
> 
> ---
>  src/vb_i2c.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/src/vb_i2c.c b/src/vb_i2c.c
> index 96e26e3..6fc95c9 100755
> --- a/src/vb_i2c.c
> +++ b/src/vb_i2c.c
> @@ -1632,6 +1632,7 @@ BOOLEAN bReadClockLine(PXGI_HW_DEVICE_INFO pHWDE)
>  		return(bReadClockLineFCNT(pHWDE));
>  	else
>  		ErrorF("Error(XGI) : Unkonwn output device! \n");
> +		return FALSE;
>  }
>  
>  BOOLEAN bReadDataLine(PXGI_HW_DEVICE_INFO pHWDE)
> @@ -1644,6 +1645,7 @@ BOOLEAN bReadDataLine(PXGI_HW_DEVICE_INFO pHWDE)
>  		return(bReadDataLineFCNT(pHWDE));
>  	else
>  		ErrorF("Error(XGI) : Unkonwn output device! \n");
> +		return FALSE;
>  }

The indentation is really messed up here.  Visually it suggests that
the return FALSE is part of the else clause, but there are no curly
braces to make it so.


More information about the xorg-devel mailing list