[PATCH] Fix build regression on ia64.

Jeremy Huddleston jeremyhu at apple.com
Fri Dec 23 15:59:31 PST 2011


I'm sorry, but I fail to see why this would be the fix to your issue... Can you please provide some context.

Sent from my iPad

On Dec 22, 2011, at 19:27, Cyril Brulebois <kibi at debian.org> wrote:

> Regression introduced in aa0bfb0f133481c57762012e8e30c05ffa151423:
> |   CCLD   Xorg
> | sdksyms.o:(.data.rel+0x27d8): undefined reference to `outl'
> | collect2: ld returned 1 exit status
> 
> Explanation: outl was still declared on linux ia64, but no longer
> defined. Fix that by no longer declaring it.
> 
> Bugzilla: https://bugs.freedesktop.org/43985
> 
> Signed-off-by: Cyril Brulebois <kibi at debian.org>
> ---
> hw/xfree86/common/compiler.h |    1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
> 
> Cc: author, reviewers of the guilty commit.
> 
> Maybe that line a few lines above could go away accordingly BTW:
> #    undef outl
> 
> diff --git a/hw/xfree86/common/compiler.h b/hw/xfree86/common/compiler.h
> index 9e00d75..3d7fabb 100644
> --- a/hw/xfree86/common/compiler.h
> +++ b/hw/xfree86/common/compiler.h
> @@ -411,7 +411,6 @@ extern _X_EXPORT unsigned int inl(unsigned int port);
> #    undef inl
> extern _X_EXPORT void outb(unsigned long port, unsigned char val);
> extern _X_EXPORT void outw(unsigned long port, unsigned short val);
> -extern _X_EXPORT void outl(unsigned long port, unsigned int val);
> extern _X_EXPORT unsigned int inb(unsigned long port);
> extern _X_EXPORT unsigned int inw(unsigned long port);
> extern _X_EXPORT unsigned int inl(unsigned long port);
> -- 
> 1.7.7.3
> 


More information about the xorg-devel mailing list