[PATCH:xinput] print_version expects no arguments, so give it none

Peter Hutterer peter.hutterer at who-t.net
Wed Dec 21 21:38:16 PST 2011


On Wed, Dec 21, 2011 at 09:31:51PM -0800, Alan Coopersmith wrote:
> Fixes Solaris Studio compiler warning:
> "xinput.c", line 357: warning: argument mismatch: 1 arg passed, 0 expected
> 
> gcc ignored it because the function declaration didn't specify arguments.
> Once you specify (void) for the arguments, gcc then throws up:
> xinput.c: In function ‘main’:
> xinput.c:357:9: error: too many arguments to function ‘print_version’
> xinput.c:147:1: note: declared here
> 
> Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>

   ab352ec..c690fad  master -> master

thanks

Cheers,
  Peter

> ---
>  src/xinput.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/src/xinput.c b/src/xinput.c
> index 2d9a893..9460175 100644
> --- a/src/xinput.c
> +++ b/src/xinput.c
> @@ -143,8 +143,8 @@ static entry drivers[] =
>  
>  static const char version_id[] = VERSION;
>  
> -int
> -print_version()
> +static int
> +print_version(void)
>  {
>      XExtensionVersion	*version;
>      Display *display;
> @@ -354,7 +354,7 @@ main(int argc, char * argv[])
>      }
>  
>      if (strcmp("version", func) == 0) {
> -        return print_version(argv[0]);
> +        return print_version();
>      }
>  
>      if (strcmp("help", func) == 0) {
> -- 
> 1.7.3.2
> 


More information about the xorg-devel mailing list