[PATCH:xmag] Use lrint() from math library if available

James Cloos cloos at jhcloos.com
Tue Dec 20 22:30:21 PST 2011


>>>>> "AC" == Alan Coopersmith <alan.coopersmith at oracle.com> writes:

AC> Moves -lm from being hardcoded in Makefile.am to being added via
AC> AC_SEARCH_LIBS in configure.ac setting it in $(LIBS)

AC> Using lrint() [returns long int] instead of rint() [returns double]
AC> clears a bunch of gcc warnings of the form:
AC> "cast from function call of type ‘double’ to non-matching type ‘short int’"

AC> Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>

Should the call to floor(3) when lrint(3) is unavailable include a cast?

Otherwise,

Reviewed-by: James Cloos <cloos at jhcloos.com>

-JimC
-- 
James Cloos <cloos at jhcloos.com>         OpenPGP: 1024D/ED7DAEA6


More information about the xorg-devel mailing list