[PATCH 27/42] dix: add helper functions for adding/removing touch listeners

Peter Hutterer peter.hutterer at who-t.net
Thu Dec 15 16:48:48 PST 2011


On Thu, Dec 15, 2011 at 01:40:48PM -0200, Fernando Carrijo wrote:
> Peter Hutterer <peter.hutterer at who-t.net> wrote:
> 
> > +static void
> > +TouchAddActiveGrabListener(DeviceIntPtr dev, TouchPointInfoPtr ti,
> > +                           InternalEvent *ev, GrabPtr grab)
> > +{
> > +    if (!ti->emulate_pointer &&
> > +        (grab->grabtype == CORE || grab->grabtype == XI))
> > +        return;
> > +
> > +    if (!ti->emulate_pointer &&
> > +        grab->grabtype == XI2 &&
> > +        (grab->type != XI_TouchBegin && grab->type == XI_TouchEnd && grab->type == XI_TouchUpdate))
> 
> The above line seems suspicious.

thanks, amended locally to "!=" for all three.

Cheers,
  Peter

> 
> > +        return;
> > +
> > +    TouchAddGrabListener(dev, ti, ev, grab);
> > +}


More information about the xorg-devel mailing list