[PATCH 08/21] Xi: deduplicate button motion mask setting
chase.douglas at canonical.com
Sun Dec 11 21:53:24 PST 2011
On 12/08/2011 07:36 PM, Peter Hutterer wrote:
> No functional changes
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> Xi/exevents.c | 37 +++++++++++++++++++++++++------------
> 1 files changed, 25 insertions(+), 12 deletions(-)
> diff --git a/Xi/exevents.c b/Xi/exevents.c
> index b2e82ec..1140554 100644
> --- a/Xi/exevents.c
> +++ b/Xi/exevents.c
> @@ -704,6 +704,29 @@ ChangeMasterDeviceClasses(DeviceIntPtr device, DeviceChangedEvent *dce)
> + * Add state and motionMask to the filter for this event. The protocol
> + * supports some extra masks for moton when a button is down:
> + * ButtonXMotionMask and the DeviceButtonMotionMask to trigger only when at
> + * least one button (or that specific button is down). These masks need to
> + * be added to the filters for core/XI motion events.
I don't comprehend this comment ^^.
Functionally this is fine though. I'll assume you can clean up the
comment without further review.
Reviewed-by: Chase Douglas <chase.douglas at canonical.com>
More information about the xorg-devel