[PATCH 5/5] dix: move event filter retrieval helpers to inpututils.c

Alan Coopersmith alan.coopersmith at oracle.com
Sat Dec 10 08:40:23 PST 2011


On 12/10/11 04:55, walter harms wrote:
>> -static Mask filters[MAXDEVICES][128];
>> +Mask filters[MAXDEVICES][128];
>
> could you please add a line that explains why 128 ?

There are 128 possible events in the X11 protocol, due to:

      Every event contains an 8-bit type code. The most significant bit in
      this code is set if the event was generated from a SendEvent request.

leaving 7 bits for the event id.

http://www.x.org/releases/X11R7.6/doc/xproto/x11protocol.html#event_format

Somehow we don't seem to have ever made a MAXEVENTS #define for that, at
least I can't find one in the headers.

-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System



More information about the xorg-devel mailing list