[PATCH xserver 1/4] Replace deprecated CWARNFLAGS with BASE_CFLAGS and NO_STRICT_ALIASING_CFLAG

[Keith Packard]

On Fri, 09 Dec 2011 11:32:39 -0500, Gaetan Nadon <memsize at videotron.ca> wrote:

> The content for CWARNFLAGS will always contain -fno-strict-aliasing.

I think BASE_CFLAGS should include -fno-strict-aliasing then;
it retains compatibility with the original C standards on which the X
code is based. The alternative is to have random failures in older code
if people try to switch from CWARNFLAGS to BASE_CFLAGS without
understanding that they would also need to add the -fno-strict-aliasing
option as well.

I'd probably add -fwrapv as well as that preserves the semantics of
integer operations. The GCC idiots seem to think that it's OK to break
existing code to allow them to perform various marginally useful
optimizations...

/me still remembers spending three days figuring out that -fwrapv was
required to make nickle compile correctly.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20111209/8600cf63/attachment.pgp>