[PATCH app-xfd] Use the Automake recommended alternative to AX_DEFINE_DIR

Alan Coopersmith alan.coopersmith at oracle.com
Wed Dec 7 21:10:51 PST 2011


On 12/07/11 10:39, Gaetan Nadon wrote:
> DATADIR, like any installation variable, is not known at configure time.
> This is by design to allow setting the variable at make time.
> The AX_DEFINE_DIR macro worked around this design and consequently
> cancelled an Automake feature.
>
> The alternative method suggested by Automake ends up being simpler
> while providing the same result as AX_DEFINE_DIR but without cancelling
> any feature. It is used in the xserver for the parser and in xquartz.
>
> The AX_DEFINE_DIR macro has been removed from the Autoconf Archive.
> There are no official providers for this macro anymore.

Before automake 1.11 doing this would have contributed a lot of noise to
the build logs, but silent mode should cover this.

For simple cases like this it seems okay - in cases where we were
exporting the definition in a .h file a more complex solution may
be required.

One nit/question, should it be CPPFLAGS instead of CFLAGS?


-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System



More information about the xorg-devel mailing list