[PATCH 1/5] Remove unused function checks from configure.ac & include/*.h.in

Gaetan Nadon memsize at videotron.ca
Fri Dec 2 17:21:19 PST 2011


On Fri, 2011-12-02 at 10:48 -0800, Alan Coopersmith wrote:

> The code that used getisax to check for MMX support was moved to
> pixman
> and removed from the X server by commit eb2d7fe02f9cbc.
> 
> The code that used HAVE_MKSTEMP was deleted by the Xprint removal in
> commit 1c8bd318fbaf.
> 
> All alloca calls were removed by the patch series end in commit
> 5e363500c8,
> and used custom X checks instead of the autoconf HAVE_ALLOCA anyway.
> 
> I can find no record of HAVE_GETUID, HAVE_GETEUID, HAVE_LINK,
> HAVE_MEMMOVE,
> HAVE_MEMSET, HAVE_STRCHR, HAVE_STRRCHR, HAVE_GETOPT, HAVE_GETOPT_LONG,
> HAVE_DOPRNT, or HAVE_VPRINTF ever being used, and the calls to those
> functions are not wrapped in #ifdefs.
> (Most of those are in our baseline requirements of C89 & Unix98
> anyway.)
> 
> Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
> ---
>  configure.ac             |    7 ++-----
>  include/dix-config.h.in  |   30 ------------------------------
>  include/xwin-config.h.in |    3 ---
>  3 files changed, 2 insertions(+), 38 deletions(-)
> 
> 

Reviewed-by: Gaetan Nadon <memsize at videotron.ca>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20111202/414d72b7/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20111202/414d72b7/attachment.pgp>


More information about the xorg-devel mailing list