[PATCH 2/2] PropertyNotify filters

Adam Jackson ajax at redhat.com
Fri Dec 2 09:23:46 PST 2011


On 12/2/11 12:09 AM, Peter Hutterer wrote:
> On Thu, Dec 01, 2011 at 03:53:41PM -0500, Adam Jackson wrote:
>> +RemovePropertyFilter
>> +
>> +		window:			WINDOW
>> +		property:		LISTofATOM
>> +
>> +	This request modifies the property filter for the named window for
>> +	the requesting client.  The listed properties are removed from the
>> +	list of properties for which the client will receive events.  If
>> +	an empty list is sent, the client will revert to unfiltered (core
>> +	protocol) behaviour for PropertyNotify.
>> +
>> +	If any atom in the list does not name a defined atom, BadAtom will
>> +	be generated.  If any atom in the (non-empty) list does not match
>> +	an atom which the client has previously filtered for, BadMatch is
>> +	generated.  In either case, the property filter list is unchanged.
>> +
>> +	Errors: Window, Atom, Match
>
> I don't think we're short on request codes but RemovePropertyFilter could be
> added with a mode: Remove. Though renaming the request to SetPropertyFilter
> would be sensible then.

Yeah, I went back and forth on doing this as two requests or one.  Might 
as well redo it as just one to be conservative with request numbers. 
Also REST I guess.

- ajax


More information about the xorg-devel mailing list