[PATCH:libX11] Reject negative string counts in copy_string_list
Alan Coopersmith
alan.coopersmith at oracle.com
Thu Dec 1 20:21:36 PST 2011
Silences parfait warning of a potential memory leak:
Memory leak of pointer 'dst' allocated with malloc(length)
at line 160 of FSWrap.c in function 'copy_string_list'.
'dst' allocated at line 145 with malloc(length).
dst leaks when count <= 0 at line 154.
Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
---
src/FSWrap.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/FSWrap.c b/src/FSWrap.c
index 45a2c34..910e602 100644
--- a/src/FSWrap.c
+++ b/src/FSWrap.c
@@ -130,7 +130,7 @@ copy_string_list(
char **string_list_ret, **list_src, **list_dst, *dst;
int length, count;
- if (string_list == NULL || list_count == 0)
+ if (string_list == NULL || list_count <= 0)
return (char **) NULL;
string_list_ret = (char **) Xmalloc(sizeof(char *) * list_count);
--
1.7.3.2
More information about the xorg-devel
mailing list