[PATCH v2:x11proto] Fix Xfuncproto.h to work when #included in a C89-mode compilation

Julien Cristau jcristau at debian.org
Tue Aug 30 10:37:33 PDT 2011


On Mon, Aug 29, 2011 at 23:09:49 -0700, Alan Coopersmith wrote:

> Variable argument macros are not supported in C89, only C99 or a
> compiler-specific extension like gcc's.   Even just defining the
> macro causes builds with C89 compilers to fail, as they can't
> figure out how to handle #define _X_NONNULL(...), so only define
> the fallback for C99 compilers.
> 
> Since this means C89 compilers will see _X_NONNULL unexpanded in
> sources, add a comment to remind users that this should only be
> used with #ifdef _X_NONNULL guards in public/exported API headers
> we install for other software to compile against, so that we don't
> break their builds.
> 
> Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
> ---
> 
> Updated commit comment and header comment from "never in public headers"
> to "okay in public headers, but only inside an #ifdef guard".
> 
>  Xfuncproto.h.in |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
Seems reasonable.

Reviewed-by: Julien Cristau <jcristau at debian.org>

Cheers,
Julien


More information about the xorg-devel mailing list