[PATCH xts] xts5: XCreateColormap-11: Bogus visuals return BadMatch, not BadValue

Aaron Plattner aplattner at nvidia.com
Mon Aug 29 23:01:14 PDT 2011


According to the X11 protocol specification,

  "The visual type must be one supported by the screen (or a Match
   error results)."

It does not say anything about invalid visual IDs causing Value
errors.

Reported-by: Nalluri Harikrishna <nharikrishna at nvidia.com>
Reported-by: Rahul Singhal <rasinghal at nvidia.com>
Signed-off-by: Aaron Plattner <aplattner at nvidia.com>
---
 xts5/Xlib7/XCreateColormap.m |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/xts5/Xlib7/XCreateColormap.m b/xts5/Xlib7/XCreateColormap.m
index 272b6f0..ec825b1 100644
--- a/xts5/Xlib7/XCreateColormap.m
+++ b/xts5/Xlib7/XCreateColormap.m
@@ -600,20 +600,20 @@ error occurs.
 >>ASSERTION Bad A
 When xname is called with an invalid visual,
 then a
-.S BadValue
+.S BadMatch
 error occurs.
 >>STRATEGY
 Make a visual structure invalid using badvis.
 Create a colourmap for this visual with XCreateColorMap.
-Verify that a BadValue error occurred.
->>CODE BadValue
+Verify that a BadMatch error occurred.
+>>CODE BadMatch
 Visual	vi;
 
 	alloc = AllocNone;
 	badvis(&vi);
 	visual = &vi;
 	XCALL;
-	if(geterr() == BadValue)
+	if(geterr() == BadMatch)
 		PASS;
 >>ASSERTION Bad A
 .ER BadWindow
-- 
1.7.4.1



More information about the xorg-devel mailing list