[PATCH 1/2] rotate: Unregister damage across modesetting

[Chris Wilson]

On Thu, 25 Aug 2011 07:10:40 -0700, Keith Packard <keithp at keithp.com> wrote:
Non-text part: multipart/signed
> On Thu, 25 Aug 2011 14:46:07 +0100, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> 
> > The driver is at liberty to modify the Screen Pixmap, for example if it
> > creates a new ordinary Pixmap for use as a shadow scanout buffer, and so
> > the cached registration of the damage may become stale and lead to an
> > eventual crash.
> 
> Is there some reason ModifyPixmapHeader isn't sufficient for this? We've
> strenuously avoided changing the PixmapRec itself.

We've been fixing bugs in the Xserver ever since we started using
a shadow pixmap and resizing upon modeset. And discovered that the other
drivers were working around the Xserver bugs...
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre