[PATCH xwininfo] Use AM_ICONV

[Yaakov (Cygwin/X)]

On Tue, 2011-08-23 at 17:11 -0400, Gaetan Nadon wrote:
> I did notice this issue. We are using AM_ICONV from the gettext
> package, not because we need the gettext package functionality, but
> because we need the nice work done in AM_ICONV. That's how I
> understand it, I am no expert.

You're completely correct.

> Using AM_ICONV is a workaround to begin with, so I thought adding
> config.rpath isn't much of an issue. The AM_ICONV checks for the
> presence of the file, I am not sure it even uses it. 

It is used by AC_LIB_RPATH (lib-link.m4), which is used by AM_ICONV.

> Nothing wrong per say, other than being "heavier", but it creates an
> additional dependency autopoint. On the plus side, the gettext package
> is properly initialized and it can now be used for translation files.

Which won't help without the necessary changes to the code itself.  (Not
that I'm opposed to l10n, but that's not my point here.)  Otherwise,
this would greatly increases the tarball size and the build time with
absolutely no benefit. 


Yaakov
Cygwin/X