[PATCH] clarify RRDeleteOutputProperty for immutable properties

Luc Verhaegen libv at skynet.be
Wed Aug 10 07:56:24 PDT 2011


On Wed, Aug 10, 2011 at 01:46:58PM +0100, Daniel Stone wrote:
> On Wed, Aug 10, 2011 at 01:10:32PM +0200, Luc Verhaegen wrote:
> > Signed-off-by: Luc Verhaegen <libv at skynet.be>
> > @@ -866,9 +866,11 @@ dynamic changes in the display environment.
> >  ????????????
> >  	Errors: Atom, Output
>                             ^^^^^^^^
>                             , Access

I completely missed that one.

> > +	If the specified property does not exist, a Match error is returned. If
> > +	the property is marked 'immutable', an Access error is returned.
> 
> s/Match/Atom/

True. But it really needs further quantification: it could be that the 
property does not belong to this output. The code in the other patch 
handles that, and it is that one that returns the Match error.

New patch coming up.

... Although... After scrolling up a bit in randproto.txt...

For RRQueryOutputProperty it states the following:

"If the specified property does not exist for the specified output,
then a Name error is returned."

Or in ProcRRQueryOutputProperty

    prop = RRQueryOutputProperty (output, stuff->property);
    if (!prop)
	return BadName;

I will need to change this in rrproperty.c as well.

Luc Verhaegen.


More information about the xorg-devel mailing list