[PATCH 3/4] Send a USER_LOGIN event like other Linux login programs do.

Alan Coopersmith alan.coopersmith at oracle.com
Mon Aug 8 13:08:30 PDT 2011


On 08/08/11 12:26, Matěj Cepl wrote:
> +AC_ARG_WITH(libaudit,
> +  [  --with-libaudit=[auto/yes/no]  Add Linux audit support [default=auto]],,
> +  with_libaudit=auto)

AS_HELP_STRING please.  See existing examples in configure.ac or
https://www.gnu.org/software/autoconf/manual/html_node/Pretty-Help-Strings.html

> @@ -600,6 +630,7 @@ greet_user_rtn GreetUser(
>  	if ((pam_error == PAM_SUCCESS) && (Verify (d, greet, verify))) {
>  	    SetPrompt (login, 1, "Login Successful", LOGIN_TEXT_INFO, False);
>  	    SetValue (login, 1, NULL);
> +		log_to_audit_system(*pamhp, 1);
>  	    break;
>  	} else {
>  	    /* Try to fill in username for failed login error log */
> @@ -611,6 +642,7 @@ greet_user_rtn GreetUser(
>  					 (void *) &username));
>  	    }
>  	    FailedLogin (d, username);
> +		log_to_audit_system(*pamhp, 0);
>  	    RUN_AND_CHECK_PAM_ERROR(pam_end,
>  				    (*pamhp, pam_error));
>  	}

Please align with current indentation levels.

-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System



More information about the xorg-devel mailing list